DiscIO: Fix decompressing writing the wrong number of bytes sometimes #8740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue cannot happen with good dumps due to their size, but it can happen with trimmed dumps.
This issue cannot happen with good dumps due to their size, but it can happen with trimmed dumps.
We can use subtraction and std::min instead of modulo and explicit if statements. This commit does not change the behavior.
JosJuice
force-pushed
the
fix-decompress
branch
from
2a63073
to
19e9a9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
These issues cannot happen with good dumps due to their size, but they can happen with trimmed dumps.