Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VideoBackends: Disable GPU Texture Decoding under MoltenVK #8743

Merged
merged 1 commit into from Sep 10, 2020

Conversation

Techjar
Copy link
Contributor

@Techjar Techjar commented Apr 13, 2020

It's broken and causes spectacular artifacts and crashes. Here's an example of what those look like:

I don't know if the problem has been fixed upstream in MoltenVK. If someone else wants to look into that, by all means, I lack the in-depth knowledge of the video backends to do that myself. In the meantime this seems like a reasonable solution to most of the reports of crashes when using Vulkan on MacOS, due to users not being aware the feature is broken.

@MayImilae
Copy link
Contributor

Here are some logs of the GPU Texture Decoding + MoltenVK crash, for anyone interested.

@pizuz
Copy link

pizuz commented Apr 13, 2020

The artifacts have been fixed in MoltenVK since 1.0.35 (including the version currently shipping with Dolphin). The crash is actually a regression from #7753. See also:

https://bugs.dolphin-emu.org/issues/11819

@Techjar
Copy link
Contributor Author

Techjar commented Apr 13, 2020

Well okay, but that is such a large PR there's absolutely no way to narrow down a cause without some good old fashioned debugging, of which I lack the knowledge to do in this area. Until someone with the necessary knowledge has the motivation to actually debug it, at least quelling the support threads on the forum seems reasonable.

@pizuz
Copy link

pizuz commented Apr 13, 2020

Do you have a Fifolog of that particular scene?

@gilcel
Copy link

gilcel commented Apr 13, 2020

@Techjar: Which macOS version do you use and which Mac / GPU ? I tried with the latest Dolphin on a Mac mini 2012 with IGP Intel HD 4000 and a Macbook Air 2013 with Intel HD 5000 and it crashes immediately when enabling GPU Texture Decoding...I don't even get this screen with artifacts, as reported here: https://bugs.dolphin-emu.org/issues/11819

@pizuz
Copy link

pizuz commented Apr 13, 2020

@gilcel: The screenshot was most likely captured prior to #7753. Meanwhile MoltenVK fixed the glitch in v1.0.35 (Vulkan SDK 1.1.108.0). You can still observe it in Wind Waker, because it manages to display the Nintendo and Dolby ProLogic logo before crashing. Mind that #8110 updated MoltenVK to a glitch-free version.

@Techjar
Copy link
Contributor Author

Techjar commented Apr 13, 2020

Yeah I was informed that MoltenVK no longer causes those artifacts, it just crashes.

@pizuz
Copy link

pizuz commented Apr 14, 2020

@Techjar: I was just mentioning this, because you listed the glitches as one of the reasons for opening this PR.

@pizuz
Copy link

pizuz commented Jun 3, 2020

The current MoltenVK release 1.0.42 (for Vulkan SDK 1.2.141) fixes the crash. However there seems to be an issue anyway, because you have to start a game twice in order for it to actually display correct textures.

Screenshot 2020-06-03 at 22 18 59

@MayImilae
Copy link
Contributor

Still crashing for me in latest master, though it gets further than before. Either way, crashing or at best hella glitching is means we should just disable gpu texture decoding in moltenvk. At least in the UI.

It's broken and causes spectacular artifacts and crashes.
@Techjar Techjar force-pushed the apple-pls-support-standard-api branch from ccde8fa to 69358b2 Compare September 7, 2020 21:28
@JMC47
Copy link
Contributor

JMC47 commented Sep 10, 2020

How does this Pull Request affect the GUI? Is the checkbox just grayed out?

@JosJuice
Copy link
Member

Yes, the checkbox is grayed out when using Vulkan on macOS.

@JMC47 JMC47 merged commit dcbe9da into dolphin-emu:master Sep 10, 2020
10 checks passed
@ghost
Copy link

ghost commented Sep 13, 2020

This PR does not gray out the checkbox on my 13" 2020 MBP. Does it still need work or was it rolled back due to issues and not mentioned?

Screen Shot 2020-09-13 at 10 52 26 AM

Screen Shot 2020-09-13 at 10 54 47 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants