Qt/Debugger: Refresh on savestate load. #8745
Merged
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at this a bit more, maybe we should just emit a |
AdmiralCurtiss
force-pushed
the
savestate-load-callback-qt
branch
from
4395bb3
to
330c800
Compare
|
Yeah I think this is better. This also fixes various windows (most noticeably the Memory window) not updating when stepping code. |
leoetlino
reviewed
Apr 27, 2020
| Host::Host() = default; | ||
| Host::Host() | ||
| { | ||
| State::SetOnAfterLoadCallback([this] { Host_UpdateDisasmDialog(); }); |
There was a problem hiding this comment.
Looks like this was lost during the move to Qt, heh. SetOnAfterLoadCallback is unused in master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pretty self-explanatory. The debugger windows would show stale data after a savestate load when the emulator was in a paused state.
I'm not sure if this is a good place to put theSee comments below.SavestateLoadedsignal, but theEmulationStateChangedis already there so... maybe?