Android: Add Install WAD to menu_game_grid #8748
Conversation
|
Haven't tested it, but the code seems fine. One comment, though: I know that one of the Android contributors we've had before has been pickier than me about making sure that long-running operations run on a separate thread so that the UI remains responsive. Importing a WAD likely counts as such an action, since it involves reading and writing tens of megabytes to storage. You might want to consider moving it to a different thread, but I personally don't consider this to be a blocker. |
|
I've never written multi-threaded code so please correct me if I'm misunderstanding something here. Wouldn't we want WAD installation to block on the UI thread here? We don't want users to begin emulation if a WAD is being installed. A toast is also given for success or failure so users will be notified when WAD installation finishes. |
I guess that is a good idea, but that can be done without blocking the UI thread. (For instance, it's possible to show an "installing" dialog that prevents the user from interacting with the UI behind... Though I guess that might be unnecessary if WAD installation is quick enough.) The reason why blocking the UI thread is bad is because it can make users think that the app has frozen, and Android can even show the "application not responding" message if it goes on for a few seconds. But again, I don't consider this a blocker, since WAD installs don't take all that long. |
|
@JosJuice let's avoid the (very unlikely) chance for ANRs. Please check to make sure my latest commit is the best way to accomplish this. |
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/MainPresenter.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/MainPresenter.java
Outdated
Show resolved
Hide resolved
Ebola16
force-pushed
the
WAD
branch
2 times, most recently
from
f639cc6
to
4a4a954
Compare
|
@JosJuice Ok, this implementation should be a little more standard. |
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/MainPresenter.java
Outdated
Show resolved
Hide resolved
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/MainPresenter.java
Show resolved
Hide resolved
|
The |
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/ui/main/MainPresenter.java
Outdated
Show resolved
Hide resolved
|
@JosJuice Done |
|
I think this is good to merge. |
|
Good afternoon. This option is not available in the Android TV Dolphin menu. Can you add it? Tested on Dolphin 5.0-12031 |
|
I'll look into that. |
Implements https://bugs.dolphin-emu.org/issues/10788
Useful for setting up mod loaders.