IOS/FS: Fix FST write failure on some platforms #8750
Merged
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes Medal of Honor Vanguard not finding save files. |
JosJuice
reviewed
Apr 18, 2020
On some platforms (like Windows), the temporary file must be closed before it can be renamed. I guess nobody noticed this for so long because (1) the FS code has a failsafe for missing FST entries (because existing users do not have a FST), and most games do not care about file metadata; (2) the write failures can only be seen in the logs. Because we don't want this to break, I have turned the ERROR_LOGs into PanicAlerts.
leoetlino
force-pushed
the
close-before-rename
branch
from
5c0476f
to
b2cf106
Compare
|
Done |
JosJuice
approved these changes
Apr 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
On some platforms (like Windows), the temporary file must be closed
before it can be renamed.
I guess nobody noticed this for so long because (1) the FS code has a
failsafe for missing FST entries (because existing users do not have
a FST), and most games do not care about file metadata;
(2) the write failures can only be seen in the logs.
Because we don't want this to break, I have turned the ERROR_LOGs into
PanicAlerts.