Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary EFB to Texture disabling for Spider-Man 2 #8752

Merged
merged 1 commit into from Apr 22, 2020
Merged

Remove unnecessary EFB to Texture disabling for Spider-Man 2 #8752

merged 1 commit into from Apr 22, 2020

Conversation

TheRealPSV
Copy link
Contributor

Removed unnecessary EFBToTextureEnable=False for Spider-Man 2 from GK2.ini, as the game no longer requires it
Also removed empty config blocks

I've been testing with EFB to Texture enabled extensively for some time, and the game works just fine.

Removed unnecessary EFBToTextureEnable=False for Spider-Man 2, as the game no longer requires it
Also removed empty config blocks
@JMC47
Copy link
Contributor

JMC47 commented Apr 19, 2020

In older builds, the game had a lot of graphical errors at night-time with EFB Copies to Texture Only enabled. I'm unsure of what could have fixed it, though.

@TheRealPSV
Copy link
Contributor Author

I'm not sure either, that's strange. I've actually been forcing EFBToTextureEnabled=True in my user-specific ini for it for over a year, and I've never seen any issues come out of it. I wonder if it could be related to the move to VideoCommon, or something related to the old depth issue.

@JMC47
Copy link
Contributor

JMC47 commented Apr 19, 2020

I can confirm the graphical glitches are gone. If someone else is okay with the empty blocks being removed, then this is fine. It's a pretty big performance boost.

@JosJuice
Copy link
Member

Could it be paletted EFB copies? Those didn't work with EFB to texture back when this game INI was created.

Removing the empty blocks is fine.

@TheRealPSV
Copy link
Contributor Author

Great! Are you comfortable merging it in then?

@JosJuice JosJuice merged commit c9aab4f into dolphin-emu:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants