IOS/NET: Add timeout on blocking connect

[sepalani]

This PR adds a timeout on connect for blocking sockets based on this hardware test. Beware that it tries to connect to an ubisoft server (which timeout after ~3 minutes on hardware).

wii-connect-timeout.zip

I'll need to reverse IOS to confirm that behaviour, however. The timeout value (in second) can also be changed in the config file under the [Network] section.

[sepalani]

@leoetlino
Done. I'm still open for a better name regarding the DoTimeout() method.

[leoetlino]

StartOrCheckTimeout maybe? Naming is hard...

[iwubcode]

I'm not great at naming either. I can only offer my thoughts. For boolean functions, I usually use 'is' or 'has', so maybe HasTimedout() ?

[lioncash]

You may wish to relocate this comment on top of the definition so that the wonky formatting can be avoided.

The comment can just be formatted to indicate it means the default value.

// Default value based on https://dolp.in/pr8759 hwtest

[sepalani]

@lioncash
Done.

@iwubcode
As @leoetlino said, the initial name was HasTimeout but the function doesn't only check for a boolean value but starts the timer on-the-fly if needed and then checks if a timeout occurred.

[sepalani]

Rebased on latest master, I also added a reference to an RFC regarding the TCP connection failures.

[sepalani]

@leoetlino
Done. Rather than splitting it into 2 functions, I decided to create simple GetTimeout function and perform the check inside the if statement.

[leoetlino]

Sorry, I missed something important in my previous review: this should be using a steady_clock, not a system_clock. The latter isn't monotonic and can be changed at any time by the user.

[sepalani]

Good catch, I completely forgot about that.

I also updated the RFC comment since it's recommending this timeout to be at least 3 minutes.