Require minizip 2.0.0 or newer #8776
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minizip 1.x is the old broken version, while 2.x is the newer fork we use. Many distros ship the old version which is causing stack smashing in RedumpVerifier, so we'll only use the shared lib if it's the newer version.
lioncash
approved these changes
Apr 29, 2020
|
The stack smashing is because of a header to lib mismatch. So indeed, the fork might be better. However the crash is because of a wrong include directory. GIT_ROOT/Externals must not be within the include directories. This PR is not needed any more after #8780 is merged. |
|
Ah, yeah I did not know about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Minizip 1.x is the old broken version, while 2.x is the newer fork we use. Many distros ship the old version which is causing stack smashing in RedumpVerifier, so we'll only use the shared lib if it's the newer version.