Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain how to fix "Serial and/or version data is missing" #8782

Merged
merged 1 commit into from Oct 23, 2020

Conversation

Pokechu22
Copy link
Contributor

The downloads page on redump doesn't link to the version that has serials and versions. Since the Wii data needs to be manually downloaded, it's easy to download the version without them (if you have access to them, of course), and it's not immediately obvious how to get the right version. I only found out by looking at the code that does the downloading for GC data. This PR amends the message to explain how to include that data in the download.

@JosJuice
Copy link
Member

JosJuice commented May 1, 2020

The intent was that Redump would make the Wii data public relatively soon and nobody would need to download the datfile manually and put it in the Cache folder in an undocumented way, but... Well, apparently Redump isn't going to be making that public any time soon. So I guess doing this type of clarification is fine. However, I'm not sure how clear users will find the current wording. Also, you should add an i18n comment telling translators to leave "serial,version" exactly as-is, not even modifying punctuation or whitespace.

@mbc07
Copy link
Contributor

mbc07 commented May 1, 2020

The intent was that Redump would make the Wii data public relatively soon [...]

Redump waits at least one full year after the release of the last official game of a given platform before making the DAT file public. Thanks to Ubisoft not letting the Wii die with yearly Just Dance releases (Just Dance 2020 last year was the last, however), that means the Wii DAT file won't go public until at least late 2020 or early 2021...

@JosJuice
Copy link
Member

JosJuice commented May 1, 2020

Do you know where you get the one year number from? What I recall is ten years, though I can't actually find where this was originally stated.

@mbc07
Copy link
Contributor

mbc07 commented May 2, 2020

I won't find the exact source now but I remember stumbling over this "one year" rationale a few times when I was searching for the Wii DAT file in the past...

@Pokechu22
Copy link
Contributor Author

Even when the data is public, it'll be useful to have additional information present in the event that someone manually downloads it.

I'm not sure exactly how to make the message clearer; one possibility would be to add something like (for instance, http://redump.org/datfile/gc/serial,version) but that seems a bit awkward.

@Pokechu22 Pokechu22 force-pushed the missing-serial-version-data branch 2 times, most recently from 34e0452 to f423962 Compare October 21, 2020 22:20
@leoetlino leoetlino merged commit 285b926 into dolphin-emu:master Oct 23, 2020
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants