Fix Windows CMake build errors #8789
Merged
+51
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosJuice
force-pushed
the
windows-cmake-errors
branch
from
76c0be2
to
f7362b6
Compare
iwubcode
reviewed
May 2, 2020
| static QString GetAddressAndPort(const sockaddr_in& addr) | ||
| { | ||
| char buffer[16]; | ||
| const char* addr_str = inet_ntop(AF_INET, &addr.sin_addr, buffer, sizeof(buffer)); |
There was a problem hiding this comment.
What's the advantage of this vs the inet_ntoa that you were using before? Any concerns with the buffer not being large enough?
There was a problem hiding this comment.
Visual Studio gives me a warning when I use inet_ntoa, and that warning gets turned into an error by our build settings. I don't know much beyond that, though I did find this comment when searching for more info about it: SFML/SFML#1023 (comment)
leoetlino
reviewed
May 3, 2020
leoetlino
reviewed
May 3, 2020
Lambda expressions with uncaptured constants were leading to errors, and there were also some warnings about deprecated functions (QFontMetrics::width and inet_ntoa).
JosJuice
force-pushed
the
windows-cmake-errors
branch
from
f7362b6
to
bf57abc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Lambda expressions with uncaptured constants were leading to errors, and there were also some warnings about deprecated functions (QFontMetrics::width and inet_ntoa).