Socket: Fix ENOTCONN error code #8796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
reviewed
May 6, 2020
| @@ -50,7 +50,7 @@ char* WiiSockMan::DecodeError(s32 ErrorCode) | |||
| #endif | |||
| } | |||
|
|
|||
| static s32 TranslateErrorCode(s32 native_error, bool isRW) | |||
| static s32 TranslateErrorCode(s32 native_error, bool is_rw) | |||
There was a problem hiding this comment.
I know nothing about this code. Is is_rw mean "read"/"write"?
There was a problem hiding this comment.
It refers to read/write or rather send(to) and recv(from).
The following functions can return
- EAGAIN/EWOULDBLOCK:
send(to),recv(from),accept - EINPROGRESS:
connect,bind - WSAEWOULDBLOCK:
send(to),recv(from),accept,connect
It is used below to correct windows error codes WSAEWOULDBLOCK as it can be used in functions which don't return EAGAIN/EWOULDBLOCK but EINPROGRESS on Linux. Basically, the Linux code path will always return -SO_EAGAIN
I can add a comment about it if you want.
There was a problem hiding this comment.
I think it might be more the naming than the usage. Not too sure if spelling out the words would help tho...
10 tasks
|
Rebased on latest master, I also added a comment regarding |
iwubcode
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
For some reason, Dolphin returns
EAGAINrather thanENOTCONN.In some circumstances, it creates an infinite loop. For instance, using
sendwith a socket which is not connected.Is there any reason to keep this legacy value? As far as I know,
ENOTCONNis only returned by the following functions:recv,recvfromsend,sendtoshutdownReady to be reviewed.