NetworkWidget: Add Blocking column #8808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
reviewed
May 12, 2020
sepalani
force-pushed
the
net-widgets-block
branch
from
c20cf38
to
4bf7c3e
Compare
|
@iwubcode |
Tilka
reviewed
Jun 14, 2020
| { | ||
| const auto& socket_manager = IOS::HLE::WiiSockMan::GetInstance(); | ||
| if (socket_manager.GetHostSocket(wii_fd) < 0) | ||
| return new QTableWidgetItem(); |
There was a problem hiding this comment.
Not saying it should be removed, but why are you checking for a host socket?
There was a problem hiding this comment.
The function is called for each possible socket fd. Some are used by the Wii and some aren't. The ones which aren't will return -EBADF, that's why I'm checking the GetHostSocket return value. The same check is done in many get functions above: if (host_fd < 0).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR adds a "Blocking" column to the Network widget telling if the socket is blocking.
Ready to be reviewed & merged.