ControllerInterface: Combine evdev devices with the same physical location in addition to unique ID #8840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pulled and tested, confirmed this fixes https://bugs.dolphin-emu.org/issues/12126 |
|
Great, now I just need someone to test the DS4 to make sure that still works as intended. |
|
Sounds good. I would test that if I had one. |
|
Unfortunately this breaks my Mayflash 4-port GameCube controller adapter. Perhaps you can examine BOTH the physical location and the unique ID? |
…ation in addition to unique ID
Techjar
force-pushed
the
evdev-combining-phys
branch
from
9065769
to
8423f84
Compare
Techjar
changed the title
|
@jordan-woyak That does appear to stop it combing the Mayflash adapter on my system. Can you confirm? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some off-brand devices always report the same unique ID, resulting in them being wrongly combined. The physical location for these devices should always be different, making that a better comparison. I'm currently unsure whether the DS4's devices (the original target of the combining behavior in #8473) all have the same physical location, but theoretically they should.