Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DolphinQt: Add fastmem option to debugger UI #8843

Merged
merged 1 commit into from Jun 14, 2020

Conversation

Techjar
Copy link
Contributor

@Techjar Techjar commented Jun 2, 2020

I'm adding this as a convenience for people like me who always forget to turn off fastmem before debugging a segfault. Less effort required than having to edit the config file manually and restart Dolphin, which might be extra inconvenient if you've gone through a bunch of steps to get to the state needed to debug an issue.

Copy link
Member

@lioncash lioncash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inclined to find this feature undesirable in its current form if it's conditionally disabled all the time. This just changes what needs to be remembered (the ENABLE_FASTMEM_OPTION flag, as opposed to remembering to disable it in the config file).

I see no reason why this can't be an option that's only enabled when the debugger is active (like with several other options). So I don't see a need to split this off into its own build type.

All user-facing strings, regardless of who sees it should be localized as well. Assuming all developers will only ever be comfortable with reading English by default, rather than their primary language is a pretty silly assumption to make, as well as bad UX.

@Techjar
Copy link
Contributor Author

Techjar commented Jun 2, 2020

Hmm, true, I guess it could just be in the JIT menu. For the record, CMake remembers the flags you set for a given build cache. The assumption about translation was made under the premise that only a literal handful of users will actually see the string, since it would only be in special builds with the flag set, making it not worth the translators' time.

@lioncash
Copy link
Member

lioncash commented Jun 2, 2020

For the record, CMake remembers the flags you set for a given build cache.

Sure, and integrating it into the debugger UI gets rid of needing to remember to pass a flag entirely. It's just there in the UI ready to be used whenever the debugger is active.

The assumption about translation was made under the premise that only a literal handful of users will actually see the string ...

We already translate the debugger UI which, by itself, isn't intended to be used by the common user. Not translating the option would be pretty out of sync with everything else.

@Techjar Techjar changed the title DolphinQt: Add fastmem UI option (with compiler flag) DolphinQt: Add fastmem option to debugger UI Jun 2, 2020
@Techjar
Copy link
Contributor Author

Techjar commented Jun 2, 2020

Alright, I've now made it an option under the JIT menu in the debugger. This way it can be accessed in normal builds rather than requiring a compiler flag, but it's still hidden away enough that the average user won't touch it.

@Tilka Tilka merged commit ad85012 into dolphin-emu:master Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants