DolReader: treat overly large data segment as bss #8855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why is shuffle2 not auto trusted @dolphin-emu-bot rebuild |
|
Good question. Sent an invite to be added to the trusted devs |
|
tbh i don't really want to feel like i have responsibilities to the dolphin project. I've removed myself from everything related a while ago. considering the extremely low amount of patches I submit now, I think that's fine. |
|
The trusted devs role doesn't really have any responsibilities (other than, y'know, not being malicious with the build system). It's just for people that are trustworthy enough that the buildbot can automatically proceed for them. Nothing more, nothing less. Either way, I respect the decision |
|
However, someone could still merge it at some point. |
lioncash
approved these changes
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
some homebrew sets
dataOffset[i]+dataSize[i]larger than file size