Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default netplay buffer to 5. #886

Merged
merged 1 commit into from Aug 29, 2014

Conversation

RachelBryk
Copy link
Member

No description provided.

@JMC47
Copy link
Contributor

JMC47 commented Aug 27, 2014

For more of an explanation, the average ping we get in a national context in the netplay group is around 60 - 70 ping, which lines up to about 5 buffer. A lot of people not wanting to touch the buffer setting think that it will break things, so we'd rather have the buffer be around average, instead of 20, which is very difficult to play any game at.

@delroth
Copy link
Member

delroth commented Aug 27, 2014

@RachelBryk: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge.


20 is a crazy value indeed if it maps to 240-300 ping. LGTM.

@dolphin-emu-bot allowmerge

dolphin-emu-bot added a commit that referenced this pull request Aug 29, 2014
Change default netplay buffer to 5.
@dolphin-emu-bot dolphin-emu-bot merged commit d159bc9 into dolphin-emu:master Aug 29, 2014
@RachelBryk RachelBryk deleted the netplay-buffer branch September 22, 2014 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants