New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JitArm64: no intermediate rounding for FMA #8870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested.
Logic however looks solid to me.
This comment has been minimized.
This comment has been minimized.
It is the JIT recompiler for ARM CPUs, which shows up as "JIT ARM64 Recompiler" on Android and "JIT Arm64 (experimental)" in DolphinQt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
untested, but the code looks very good.
Tested two games on my phone, with no problems observed. This is probably just me not being used to ARM assembly (so I don't mind if someone merges without me getting an answer), but why do we need a special case for |
@JosJuice Thanks for testing. PPC has the 4 operant isntruction ( |
This PR is breaking stuff in Sonic Unleashed: https://youtu.be/CWRrhoeGArE Notably, stick inputs are now incorrect. This should probably be reverted for the time being until more testing can happen :/ |
@MANGOM1LK Spotted an obvious bug. Please try the following build: https://dolphin.ci/#/builders/15/builds/1251 |
Completely untested atm.