Sketchy code cleanup in GCMemcard and GCMemcardDirectory. #8880
+12
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lioncash
reviewed
Jun 16, 2020
AdmiralCurtiss
force-pushed
the
gcmemcard-sketchy-code-cleanup
branch
from
a0e1364
to
2d5bf8a
Compare
AdmiralCurtiss
force-pushed
the
gcmemcard-sketchy-code-cleanup
branch
from
2d5bf8a
to
d753843
Compare
|
Anything else? I cleaned up the static asserts. |
AdmiralCurtiss
force-pushed
the
gcmemcard-sketchy-code-cleanup
branch
from
d753843
to
3010523
Compare
iwubcode
reviewed
Jul 12, 2020
iwubcode
approved these changes
Jul 12, 2020
|
Can we get a rebase, please? |
|
Oh, did this break? Sure, gimme a sec... |
AdmiralCurtiss
force-pushed
the
gcmemcard-sketchy-code-cleanup
branch
from
3010523
to
7abe1b6
Compare
|
Rebased. |
jordan-woyak
approved these changes
Jul 20, 2020
AdmiralCurtiss
force-pushed
the
gcmemcard-sketchy-code-cleanup
branch
from
7abe1b6
to
b175c20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Just some cleanup of undefined behavior and unclear code. Should not change program behavior.
(Yes, ClearBlock() really dir call a member function on the wrong class. I'm amazed this worked at all.)