Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Call Movie::FrameUpdate per field, not per line #8889

Merged
merged 1 commit into from Jun 27, 2020

Conversation

JosJuice
Copy link
Member

Fixes https://bugs.dolphin-emu.org/issues/12066.

I must've only tested the frame counter with an earlier version of the PR that broke this, not the final version...

@JosJuice JosJuice changed the title Core: Don't call Movie::FrameUpdate way too often Core: Call Movie::FrameUpdate per frame, not per line Jun 20, 2020
@JosJuice JosJuice force-pushed the movie-frame-update-frequency branch from a103647 to 1852159 Compare June 20, 2020 17:12
Fixes https://bugs.dolphin-emu.org/issues/12066.

I must've only tested the frame counter with an earlier version
of the PR that broke this, not the final version...
@JosJuice JosJuice force-pushed the movie-frame-update-frequency branch from 1852159 to 9eb36af Compare June 20, 2020 17:32
@JosJuice JosJuice changed the title Core: Call Movie::FrameUpdate per frame, not per line Core: Call Movie::FrameUpdate per field, not per line Jun 20, 2020
Copy link
Contributor

@iwubcode iwubcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Untested

@Tilka Tilka merged commit 2e8d1dd into dolphin-emu:master Jun 27, 2020
@JosJuice JosJuice deleted the movie-frame-update-frequency branch June 27, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants