New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android: Remove unnecessary JNI function declarations #8893
Android: Remove unnecessary JNI function declarations #8893
Conversation
|
Wouldn't this cause -Wmissing-declarations warnings? |
|
I don't get any such warnings in the log when building this change. |
|
I was wondering about this too. From what I've read, forward declarations help reduce building time if a method has the same name and different parameters. |
|
I don't see why adding a forward declaration would improve the build time. A common thing to do with forward declarations is to replace an include with a forward declaration, which does save build time by skipping the include, but includes are not relevant for what we are doing here.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll assume I read a poorly worded stack overflow comment that actually meant forward declarations improve build time when compared to using an include. If that's the case LGTM.
d75535b
to
ee3476d
Compare
ee3476d
to
ad19904
Compare
ad19904
to
af3880d
Compare
af3880d
to
7f72a06
Compare
7f72a06
to
f3a0f9f
Compare
fbc795e
to
961fea8
Compare
We generally have no reason to call these functions on our own, so there's not much reason to declare them, especially not in the cpp file where they're defined. In case we ever do get a reason to do it, we can add declarations for just the functions that need them.
961fea8
to
439866d
Compare
We generally have no reason to call these functions on our own, so there's not much reason to declare them, especially not in the cpp file where they're defined. In case we ever do get a reason to do it, we can add declarations for just the functions that need them.