Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Add disc image conversion #8902

Merged
merged 10 commits into from Sep 23, 2020
Merged

Android: Add disc image conversion #8902

merged 10 commits into from Sep 23, 2020
+1,366 −140

Conversation

JosJuice
Copy link
Member

Screenshot_20200627-125148

@JosJuice
Copy link
Member Author

After coding this, I came to the conclusion that I don't like Android.

@JosJuice JosJuice force-pushed the android-convert branch 2 times, most recently from 215f1ab to cb28cd0 Compare June 27, 2020 11:07
@JosJuice JosJuice force-pushed the android-convert branch 3 times, most recently from 1688094 to 598c4c3 Compare July 8, 2020 12:51
@JosJuice JosJuice force-pushed the android-convert branch 4 times, most recently from 021e118 to 4506663 Compare July 22, 2020 08:25
@JosJuice JosJuice force-pushed the android-convert branch 2 times, most recently from f00128e to 0a502d6 Compare August 3, 2020 13:27
@JosJuice JosJuice force-pushed the android-convert branch 3 times, most recently from 5467604 to d5d41c0 Compare September 6, 2020 12:35
@JosJuice
Copy link
Member Author

JMC wanted to see how the progress dialog is supposed to look.

Screenshot_20200912-124959694

@JMC47 JMC47 requested a review from Ebola16 September 16, 2020 19:53
@JMC47
Copy link
Contributor

JMC47 commented Sep 16, 2020

@Ebola16 Can you give this a quick look before I yolo merge it :)

@JMC47
Copy link
Contributor

JMC47 commented Sep 23, 2020

I've tested this thoroughly and it appears that no one wants to look into the java code. Space is at a premium on phones and having this feature would be fantastic. It's been sitting here for 3 months now.

@JMC47 JMC47 merged commit 54e570a into dolphin-emu:master Sep 23, 2020
10 checks passed
@JosJuice JosJuice deleted the android-convert branch September 23, 2020 16:30
@JosJuice JosJuice mentioned this pull request Sep 23, 2020
Merged
@7aychu23

This comment has been minimized.

Sign in to view
@Sanfe
Copy link

Sanfe commented Sep 25, 2020 •
edited

I tested this feature in last beta and have a bug. In RVZ format, the compression level only could be up to 9. If you put 10 or more crash. Also, a progress bar in notification bar is needed to could make the process in background. Batch multiple compression and auto delete source file when finish conversion could be a good plus.

@JMC47
Copy link
Contributor

JMC47 commented Sep 25, 2020

The crash will be fixed tomorrow.

@JosJuice
Copy link
Member Author

I only meant I would create the PR tomorrow, not that it will be merged tomorrow :P

But yeah, it should be a simple fix.

@theOG1
Copy link

theOG1 commented Sep 28, 2020

How about the method that have been used in nkit it's fast and the size really small

@JosJuice
Copy link
Member Author

It also breaks games in certain ways, while not really being faster or smaller than RVZ.

@theOG1
Copy link

theOG1 commented Sep 29, 2020

The converting process doesn't appear in mi a3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ebola16 Ebola16

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
5 participants
@JosJuice @JMC47 @7aychu23 @Sanfe @theOG1