Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the new MSVC preprocessor #8913

Merged
merged 1 commit into from Jun 30, 2020

Conversation

JosJuice
Copy link
Member

Intends to fix https://bugs.dolphin-emu.org/issues/12170.

Untested, because I'm using VS 16.5 to avoid the std::result_of problem, and as far as I know the new preprocessor requires VS 16.6.

@BhaaLseN
Copy link
Member

FYI, I tried building this branch on 16.6.2 (along with /std:cpp17 and /experimental:newLambdaProcessor because it wouldn't build at all otherwise), and it works without /Zc:preprocessor. However, once I add that, it fails inside ucrt_math.h (included by pch) with Windows SDK 10.0.17763.0. filoppi confirmed on IRC that it does work with Windows SDK 10.0.19041.0 though, so we might also have to consider documenting this somewhere. We used to have the version in README.md, but since switched it to just say "Windows 10 SDK".

@JosJuice
Copy link
Member Author

filoppi confirmed on IRC that it does work with Windows SDK 10.0.19041.0 though, so we might also have to consider documenting this somewhere.

Since we're not actually enabling /Zc:preprocessor, is there really a need to document it?

@BhaaLseN
Copy link
Member

I'm guessing it would become the default at some point, for compatibility with other compilers? I mean, good enough for me if we want to handle it if (or when) it comes up.

@AdmiralCurtiss
Copy link
Contributor

Is there anything stopping us from upgrading Qt, by the way?

@JosJuice
Copy link
Member Author

No, other than people not knowing how to or wanting to build the new version to put in Externals.

@lioncash lioncash merged commit 4ff560a into dolphin-emu:master Jun 30, 2020
10 checks passed
@JosJuice JosJuice deleted the msvc-preprocessor branch June 30, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants