Jit64: Implement low DCBZ hack #8914
Merged
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Because the DCBZ low hack is only used during the game's boot process, this shouldn't actually affect in-game performance. May smooth out some hitches when loading through. The actual game itself is slow for the same reason that Star Wars: Rogue Squadron 2/3 are slow. |
DCBZ is used after boot too. Maybe the hack doesn't matter at that point, but the hack remains enabled, so DCBZ has to fall back to interpreter. |
|
Ah I see. If we could figure out why Dynamic BATs slowed down MMU games, we could probably get a decent performance boost if we could figure out why. |
Sintendo
reviewed
Jul 18, 2020
Tilka
reviewed
Aug 8, 2020
I was hoping this would improve the performance of Cars 2 by avoiding interpreter fallbacks, but it doesn't seem to have made any measurable impact.
JosJuice
force-pushed
the
jit64-low-dcbz
branch
from
36ff87c
to
76228fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I was hoping this would improve the performance of Cars 2 by avoiding interpreter fallbacks, but it doesn't seem to have made any measurable impact.