Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushed required version of lib-zstd to 1.4.0 or higher #8917

Merged
merged 1 commit into from Oct 21, 2020

Conversation

jwsharpe
Copy link
Contributor

No description provided.

@JosJuice
Copy link
Member

As far as I know, 1.3.8 or higher should work fine, so enforcing 1.4.4 seems a little excessive.

@jwsharpe
Copy link
Contributor Author

Was just matching the ./Externals package, can bump down to 1.3.8 if you want.

@jwsharpe jwsharpe changed the title Pushed required version of lib-zstd to 1.4.4 or higher, matching external. Pushed required version of lib-zstd to 1.4.0 or higher Jun 29, 2020
@Tilka
Copy link
Member

Tilka commented Aug 8, 2020

Was just matching the ./Externals package, can bump down to 1.3.8 if you want.

Please do.

@cyrozap
Copy link
Contributor

cyrozap commented Aug 11, 2020

Per #9017, the minimum version should probably be kept at 1.4.0, since Dolphin fails to build with zstd 1.3.8 on Debian 10.

<leoetlino: Dolphin fails to build with zstd 1.3.8.>
@leoetlino leoetlino merged commit 548bfbe into dolphin-emu:master Oct 21, 2020
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants