ControllerInterface/Wiimote: Provide fallback values for extensions with bad calibration. #8936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
approved these changes
Jul 5, 2020
There was a problem hiding this comment.
I can't speak to the low level emulation logic but the code itself seems fine. Never would have guessed it was bad calibration data as I tested this capability a while back with official Nintendo controllers.
Anyway, I tested on master to reproduce the problems with a Nunchuk and confirmed this PR fixes the issue. So... LGTM!
|
Just tested this locally against Build 12259 with Super Mario Galaxy, my Nunchuk works with Hybrid Wiimote now! (I'm musicalmitten from the linked bug tracker issue) |
lioncash
reviewed
Jul 8, 2020
| } | ||
| else | ||
| { | ||
| for (size_t i = 0; i != std::size(zero.data); ++i) |
There was a problem hiding this comment.
This can likely be a std::all_of
There was a problem hiding this comment.
I'm indexing two arrays. I don't think it can be a clean std::all_of but I'll change it to an std::equal.
jordan-woyak
force-pushed
the
wiimote-extension-calibration-fix
branch
from
ed65746
to
acdbbe4
Compare
…ith bad calibration data.
jordan-woyak
force-pushed
the
wiimote-extension-calibration-fix
branch
from
acdbbe4
to
5299e90
Compare
lioncash
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some Nunchuks and Classic Controllers have bad calibration data.
This was causing unusable inputs in ControllerInterface Wii Remotes (aka Hybrid Wiimote 2.0).
This PR adds fallback values to make things mostly usable if the calibration checksum is bad or values are not sane.
The sanity check is just that "min" and "max" values are on opposite sides of the "zero" value.
This fixes:
https://bugs.dolphin-emu.org/issues/12088
https://bugs.dolphin-emu.org/issues/12027