Android: Use system cache directory as cache directory #8949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets Android automatically delete data in the cache directory when the device is running low on space or when Dolphin is uninstalled.
|
Ideally the entire user folder should be moved to the app's own external directory (Internal Storage/Android/data/com.dolphinemu.dolphinemu/), but regardless this is a nice first step. Storage access is gonna be even more restrictive with Android 11 and we don't even support Scoped Storage yet, this is gonna bite our arses soon =/ |
|
I will work on that eventually. |
Tilka
reviewed
Jul 12, 2020
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/utils/DirectoryInitialization.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets Android automatically delete data in the cache directory when the device is running low on space or when Dolphin is uninstalled.