Common/Timer: Fix integer underflow in Timer::GetDoubleTime for dates before ~2008. #8950
+11
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-woyak
force-pushed
the
double-time-fix
branch
from
25ca90f
to
eab0786
Compare
JosJuice
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Dates before ~2008 underflowed in a
u64and were then converted to au32.The year 2000 was saved as 2136.
https://bugs.dolphin-emu.org/issues/12119
Other code in this file assumes the
time_tepoch is 1970 so I'm making that same assumption.We can safely use
time_since_epochwhen we switch to C++20.Do we want to add some hax to read times that were saved incorrectly?
I don't think it's worth it.