DolphinQt: Replace unusual Qt::InitialSortOrderRole usage with a custom role. #8959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-woyak
force-pushed
the
qt-sort-role
branch
from
0f43b06
to
8b3e9e6
Compare
lioncash
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Our usage of
Qt::InitialSortOrderRoleas the sort role in ourGameListModelis unusual.It's intended to return a
Qt::SortOrder(ascending/descending) in an entirely different overridden function.While our usage probably isn't breaking anything it's unusual and had me barking up wrong trees in Qt documentation.