Android: Clear game profiles and GameSettings #8966
Merged
+60
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ebola16
changed the title
JosJuice
reviewed
Jul 23, 2020
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/dialogs/GamePropertiesDialog.java
Outdated
Show resolved
Hide resolved
JosJuice
reviewed
Jul 23, 2020
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/dialogs/GamePropertiesDialog.java
Outdated
Show resolved
Hide resolved
Ebola16
force-pushed
the
WP
branch
3 times, most recently
from
fe82907
to
df87f6c
Compare
JosJuice
reviewed
Jul 24, 2020
Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/dialogs/GamePropertiesDialog.java
Outdated
Show resolved
Hide resolved
JosJuice
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Users may be surprised that "Clear Game Settings" doesn't also clear game profiles. I also specified when exceptions are ignored, as recommended by Android Studio.