Config: Simplify IsSettingSaveable #8971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should make it both easier to edit and faster to run.
|
This is really nice! I'm assuming |
|
Yes, that was the intent. |
|
Great, coupled with #8849 and there would be hardly any upkeep here! |
iwubcode
approved these changes
Jul 22, 2020
|
Only one of them has settings left in ConfigManager, the General section. The General section was marked as saveable before this PR, and none of the General settings that are defined in the new config system are referenced in ConfigManager, so I figured it was okay to leave it as it is. |
lioncash
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Should make it both easier to edit and faster to run.