Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Some simple Clang-Tidy suggestions #8972

Merged
merged 1 commit into from Jul 22, 2020
Merged

Android: Some simple Clang-Tidy suggestions #8972

merged 1 commit into from Jul 22, 2020

Conversation

Ebola16
Copy link
Member

@Ebola16 Ebola16 commented Jul 22, 2020

Split from #7252

JosJuice
JosJuice reviewed Jul 22, 2020
View reviewed changes
Copy link
Member

@JosJuice JosJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My personal preference is to not use auto for primitive types, but I'm not opposed to having the PR merged with the auto changes intact if others prefer it this way. The rest LGTM, other than one comment.

Source/Android/jni/MainAndroid.cpp Outdated Show resolved Hide resolved
@delroth
Copy link
Member

delroth commented Jul 22, 2020

I don't have any objection against using auto when the right side of the assignment already repeats the type (which I imagine is what clang-tidy is finding here).

@Ebola16
Copy link
Member Author

Ebola16 commented Jul 22, 2020

I'm somewhat indifferent to the auto changes but I like less complaints from Clang-Tidy.

@lioncash lioncash merged commit 8e99c77 into dolphin-emu:master Jul 22, 2020
9 checks passed
@Ebola16 Ebola16 deleted the CT branch July 22, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosJuice JosJuice JosJuice left review comments

@lioncash lioncash lioncash approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
4 participants
@Ebola16 @delroth @lioncash @JosJuice