Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GameSettings: SafeTextureCacheColorSamples for SEUPEY and SEVPEY #8977

Merged
merged 1 commit into from Jul 24, 2020

Conversation

chungy
Copy link
Contributor

@chungy chungy commented Jul 23, 2020

Works around a rendering error in Retro City Rampage (disc) and
Shakedown: Hawaii. Fixes redmine issues #12197 and #12198.

@@ -0,0 +1,4 @@
# SEUPEY - Shakedown: Hawaii
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Game ID is wrong here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, fault of me using cp :)

@JosJuice
Copy link
Member

Game INIs which contain settings should use three-character names (SEU.ini/SEV.ini) instead of six-character names, unless it can be shown that there are versions of the game that do not require the setting (which of course is not the case here since the games only have one version each). LGTM other than that.

@chungy
Copy link
Contributor Author

chungy commented Jul 23, 2020

Game INIs which contain settings should use three-character names (SEU.ini/SEV.ini) instead of six-character names

Thanks, I was not aware -- I don't really know the intricacies of Wii serial numbers nor how dolphin-emu uses them.

Works around a rendering error in Retro City Rampage (disc) and
Shakedown: Hawaii.  Fixes redmine issues #12197 and #12198.
@JosJuice
Copy link
Member

No problem. This convention is essentially something I made up a number of years ago that hasn't been formally written down, so I don't blame anyone for not knowing about it.

@JosJuice JosJuice merged commit f96f3b3 into dolphin-emu:master Jul 24, 2020
9 checks passed
@chungy chungy deleted the vblank-gamesettings branch July 24, 2020 09:19
@MayImilae
Copy link
Contributor

@chungy Do you have the titles in question? If so, could you give us before and after images for the progress report? We gotta cover a fix for the final wii game!

@chungy
Copy link
Contributor Author

chungy commented Aug 29, 2020

Yup, that's why I made the PR. I can do this soon.

RCR is still, just barely, not sold out: https://vblank-entertainment.myshopify.com/collections/frontpage/products/retro-city-rampage-dx-wii-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants