Curl: For windows cmake builds, build curl with schannel/winssl capability #8984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2dliu
changed the title
|
These are the same definitions as when building with the VS project, so the change makes sense to me. Please squash the two commits into one. |
|
done |
lioncash
reviewed
Jul 26, 2020
JosJuice
approved these changes
Jul 28, 2020
lioncash
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Added a few flags to the curl external static build so that it has ssl capabilities. otherwise, it doesn't support protocols like https and you get errors trying to send curl requests to those kind of endpoints