BTEmu/Wiimote: Fixes and Cleanups. #8985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-woyak
force-pushed
the
btemu-cleanup
branch
2 times, most recently
from
2c91e70
to
a06fb15
Compare
|
Nice work! Could be placebo but Bully Scholarship Edition seems to load a lot more quickly now with emulated Wiimotes when compared with master (though there's likely still an emulation issue with this game as GPU usage stays at 100% while the initial loading occurs) |
BhaaLseN
reviewed
Jul 26, 2020
jordan-woyak
force-pushed
the
btemu-cleanup
branch
2 times, most recently
from
2d9d6f5
to
93632bd
Compare
BhaaLseN
reviewed
Jul 26, 2020
jordan-woyak
force-pushed
the
btemu-cleanup
branch
5 times, most recently
from
632536e
to
e1c18f3
Compare
iwubcode
reviewed
Aug 9, 2020
jordan-woyak
force-pushed
the
btemu-cleanup
branch
from
e1c18f3
to
17ba1b5
Compare
iwubcode
reviewed
Aug 11, 2020
jordan-woyak
force-pushed
the
btemu-cleanup
branch
2 times, most recently
from
1a9dd1a
to
1e29e99
Compare
iwubcode
reviewed
Aug 16, 2020
iwubcode
reviewed
Aug 16, 2020
jordan-woyak
force-pushed
the
btemu-cleanup
branch
from
1e29e99
to
0ad123b
Compare
|
I tested this out last night to make sure I could connect my controllers still and it worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Cleaned up L2CAP channel establishment in
WiimoteDevice.When the ACL connection originates from the Wii it will establish HID channel connections but our
WiimoteDevicewas simultaneously doing so causing problems.ACL connection establishment is less hacky now as well.
Cleaned up our "fake" inquiry response in BTEmu.
There were a few issues there.
Now only configured remotes will respond to an inquiry.
All of that fixes Wii remote reconnection in the home menu (issue: https://bugs.dolphin-emu.org/issues/11974)
Reconciled some duplicate HID logic in Emu and Real Wiimote code.
Introduced a
HIDWiimoteinterface forWiimoteDeviceto talk to either a real or emulated source.General cleanups in related code.
Eliminated remnants of the Wii Remote "Plugin".
Advanced save state version due to cleanups.
Any TODOs I've added are things I plan to address in later PRs.
I've already made this PR too big.