JIT: fix RAM check in load-from-constant-address #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug that seems to have been uncovered by allowing immediate-address loads. Super Monkey Ball 2 crashes without this change -- it's possible, however, that the game actually requires the MMU hack, since it crashed due to accessing an address in the 0x20000000-0x3fffffff range.
|
Both Super Monkey Ball 1 and 2 have crushing issues without mmu speed hack and work ok with it now. Should i just update their gameinis? |
|
@Linktothepast: I wouldn't add settings to the gameinis that aren't actually required (unless they're still crashing with this fix) |
|
They are crashing after some previous commits in master and this one tries to remedy that. Thing is they work if mmu speed hack is enabled so the question is whether i should change their gameini files or this pr be pushed to master (which of the two is the correct approach). |
|
This is definitely the right route to take since that mask fails for that fake virtual memory location that we have. |
Sonicadvance1
added a commit
that referenced
this pull request
Aug 31, 2014
JIT: fix RAM check in load-from-constant-address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
A bug that seems to have been uncovered by allowing immediate-address loads.
Super Monkey Ball 2 crashes without this change -- it's possible, however, that
the game actually requires the MMU hack, since it crashed due to accessing an
address in the 0x20000000-0x3fffffff range.