[Android] Fix Android not calling eglSwapBuffers #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't the cleanup that GLInterface needs, but for now it makes it so it'll swap and not just black screen A cleanup to GLInterface will be coming in a couple weeks.
|
LGTM but this code is kind of a mess of #ifs mixed with ifs. Why do we not use polymorphism here instead of these series of if statements? If that makes sense to you, would appreciate if you could create an issue about that if you don't want to fix that in the near future. |
|
I do have an issue about it, I planned on rewriting it in a week or two. https://code.google.com/p/dolphin-emu/issues/detail?id=6981 I'm a bit busy with work right now, which is why I've only done these two small things. Once I get back to the US I'll have some more time available. |
delroth
added a commit
that referenced
this pull request
Jan 29, 2014
[Android] Fix Android not calling eglSwapBuffers
delroth
referenced
this pull request
Jul 12, 2014
Make the emulation stop asynchronous to prevent deadlocks.
CarlKenner
referenced
this pull request
in CarlKenner/dolphin
Dec 13, 2014
Master is merged and playable if you adjust the settings.
Merged
ghost
mentioned this pull request
rapito
added a commit
to rapito/dolphin
that referenced
this pull request
May 17, 2022
Allow toggle-ing chat messages during netplay sessions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This isn't the cleanup that GLInterface needs, but for now it makes it so it'll swap and not just black screen
A cleanup to GLInterface will be coming in a couple weeks.