Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android: Remove some static variables from SettingsAdapter #9010

Merged
merged 1 commit into from Aug 6, 2020
Merged

Android: Remove some static variables from SettingsAdapter #9010

merged 1 commit into from Aug 6, 2020

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Aug 5, 2020

All of these have non-static equivalents (mView and mClickedItem).

@JosJuice
Android: Remove some static variables from SettingsAdapter
e391173 
All of these have non-static equivalents (mView and mClickedItem).
Ebola16
Ebola16 approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@Ebola16 Ebola16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This was on my todo list as well.

@lioncash lioncash merged commit d8c0344 into dolphin-emu:master Aug 6, 2020
10 checks passed
@JosJuice JosJuice deleted the android-settingsadapter-redundant-static branch August 7, 2020 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lioncash lioncash lioncash approved these changes

@Ebola16 Ebola16 Ebola16 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@JosJuice @lioncash @Ebola16