Fix builds with system LZMA when using versions of CMake before 3.14 #9025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "FindLibLZMA.cmake" module in CMake versions prior to 3.14 do not set an alias like how Externals/liblzma/CMakeLists.txt does, so builds performed using one of those older CMake versions will fail if the system LZMA library is detected. To fix this, we need to link against "lzma" instead of "LibLZMA::LibLZMA". Fixes: b59ef81 ("WIA: Implement bzip2, LZMA, and LZMA2 decompression")
|
Seems to work for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The "FindLibLZMA.cmake" module in CMake versions prior to 3.14 do not
set an alias like how "Externals/liblzma/CMakeLists.txt" does, so builds
performed using one of those older CMake versions will fail if the
system LZMA library is detected. To fix this, we need to link against
"lzma" instead of "LibLZMA::LibLZMA".
This is an update of #9017, with the zstd build changes removed and the commit message altered to make it more clear what problem it's fixing.
This patch is needed to fix builds on Debian 10 (buster).