msvc: temporary workaround for C4789 false positive #9031
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Prevents the following, which appears to be bogus:
After some experimenting, it appears to be a fairly hard to hit edge case (as also evidenced by the fact that no code in the rest of dolphin triggers it). It has to do with the /permissive- flag and the exact way the struct is declared, concerning the ordering of named/unnamed fields. It also only repros on unoptimized builds (e.g. dolphin's Debug target).
Afterwards (and with Qt 5.15.0), dolphin builds fine on current msvc:
Microsoft (R) C/C++ Optimizing Compiler Version 19.27.29111