UnitTests: avoid using glob to find compilation units #9032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuffle2
force-pushed
the
msbuild-unittests
branch
from
d3703b0
to
998cbcb
Compare
GetFstEntryForPath may modify the children vector, so do it before taking an iterator to the vector.
Fixes VS warning / bad behavior.
shuffle2
force-pushed
the
msbuild-unittests
branch
from
998cbcb
to
d40ae8a
Compare
leoetlino
reviewed
Aug 16, 2020
Rumi-Larry
reviewed
Aug 17, 2020
Rumi-Larry
reviewed
Aug 17, 2020
leoetlino
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Using
*was always a hack, and now VS issues a warning upon solution/project load, so let's avoid hitting bad behavior by explicitly listing files.This change exposed some compiler warnings (apparently because some files were not being compiled on windows before?!), so the PR also fixes those.
Also fixes a bug in
IOS::HLE::FS::HostFileSystem::Rename(comparing to invalidated vector iterator) introduced in a40f297