Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: keep an extra reference to BluetoothApis.dll #9039

Merged
merged 1 commit into from Sep 11, 2020

Conversation

shuffle2
Copy link
Contributor

Prevents BluetoothApis.dll being continuously loaded/unloaded which is 1) very annoying during debugging 2) probably somewhat of a speed hit.

@AdmiralCurtiss
Copy link
Contributor

Ah, thanks for that. That one definitely annoyed me too but I couldn't figure out where it came from.

@Pokechu22
Copy link
Contributor

This one annoyed me too. There is actually a way to disable that message in VS, though, under Debugging → Output Window (Exception messages and threads stopping can also be disabled there).

I'm not sure if it staying open forever is a good thing; theoretically it should be closed when Dolphin exists, but I'm guessing that's something that automatically happens when the process closes.

@AdmiralCurtiss
Copy link
Contributor

Static variables get destructed when the program exits, so that's fine.

(And really, it's program exit, the OS will take care of all our garbage anyway...)

@shuffle2
Copy link
Contributor Author

This one annoyed me too. There is actually a way to disable that message in VS, though, under Debugging → Output Window (Exception messages and threads stopping can also be disabled there).

True, but I think it's beneficial to just avoid actually running the dynamic linker all the time.

@shuffle2 shuffle2 force-pushed the bt-dll branch 3 times, most recently from fa479af to ef7a02f Compare August 23, 2020 00:36
@JMC47
Copy link
Contributor

JMC47 commented Sep 11, 2020

Works on my machine.

@JMC47 JMC47 merged commit 1335df8 into dolphin-emu:master Sep 11, 2020
10 checks passed
@shuffle2 shuffle2 deleted the bt-dll branch September 11, 2020 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants