New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require msvc 19.27.29111 and Windows SDK 10.0.19041 #9048
Conversation
|
Is there a reason why those specific versions were picked? Dolphin seems to build just as well on slightly older versions. |
|
The versions in this PR are just the currently released versions. The general idea is to limit the ability of something like this "windows build isn't working by default for half a year" scenario from occurring again (while also staying on latest :)). Ideally the buildbot would automatically check for and apply toolchain/sdk releases as they become available, so CI would detect issues automatically. |
In that case, isn't what you want just for the buildbot's MSVC version to be regularly updated? I don't see why preventing people from building with older versions locally in addition to that accomplishes anything useful, and adding checks like these doesn't make updating the buildbot's MSVC version easier (or harder). |
|
There are minimum build requirements tho (for both msvc and winsdk), and it's easier to just pick what is current than caring about the details. |
|
But I agree, these compile-time checks don't need to be updated every version. |
09d203c
to
41f7732
Compare
|
Added some logging to display current version of whatever doesn't pass the checks. |
41f7732
to
31cddb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm, requiring recent-ish versions reduces possible differences between CI builds and user builds
|
This actually took so long to get merged that the versions should be updated... buildbot is already ahead |
extracted from #9037 again, we'll see if it builds