AudioInterface: Use 32029/48043 Hz in more places #9055
Conversation
In particular, I wanted to do change this in AudioInterface::Init so that dumped GC audio doesn't need to have a file split (changing from 32000 Hz to 32029 Hz) when the emulated software initializes the AI registers. I've also made the same change to DI's DTK code.
|
@iwubcode I had to add another commit to actually get rid of the file split. Could you re-review? |
| @@ -294,8 +294,11 @@ static u32 AdvanceDTK(u32 maximum_samples, u32* samples_to_process) | |||
| static void DTKStreamingCallback(DIInterruptType interrupt_type, const std::vector<u8>& audio_data, | |||
| s64 cycles_late) | |||
| { | |||
| // TODO: Should we use GetAISSampleRate instead of Get48KHzSampleRate? | |||
There was a problem hiding this comment.
I'm assuming you intend to investigate this at a later date?
There was a problem hiding this comment.
It would involve some kind of hardware testing that I'm not sure how to do. The issue (if it even is an issue) is present in master as well, so I added the comment just for clarity.
There was a problem hiding this comment.
I think the comment should expand on why we might want to use GetAISSampleRate instead, so anyone else that wants to investigate in some form has all the reasoning behind the TODO.
There was a problem hiding this comment.
I've reworded the comment in a way that hopefully should make the reason clearer.
| @@ -67,6 +68,12 @@ void InitSoundStream() | |||
| g_sound_stream->Init(); | |||
| } | |||
|
|
|||
| // Ideally these two calls would be done in AudioInterface::Init so that we don't | |||
| // need to have a dependency on AudioInterface here, but this has to be done | |||
| // after creating g_sound_stream (above) and starting audio dumping (below) | |||
There was a problem hiding this comment.
One thought is that InitSoundStream() could take the rates? And then HW could expose them via getters and those values could be passed in Core.cpp. Not sure if that's worth it though?
There was a problem hiding this comment.
Yeah, it would work but I'm not sure if it's worth it. Does anyone else have an opinion on this?
JosJuice
force-pushed
the
gc-sample-rate
branch
2 times, most recently
from
ba837ff
to
e30736d
Compare
JosJuice
force-pushed
the
gc-sample-rate
branch
from
e30736d
to
bd44106
Compare
In particular, I wanted to do change this in AudioInterface::Init so that dumped GC audio doesn't need to have a file split (changing from 32000 Hz to 32029 Hz) when the emulated software initializes the AI registers. I've also made the same change to DI's DTK code.