Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Optional AfterDirectoryInitializationRunner failure message #9062

Merged

Conversation

JosJuice
Copy link
Member

@JosJuice JosJuice commented Sep 5, 2020

This centralizes the code for showing the write_permission_needed and external_storage_not_mounted toasts. Split out from PR #8962.

This centralizes the code for showing the write_permission_needed
and external_storage_not_mounted toasts.
@JosJuice JosJuice force-pushed the android-dir-init-fail-message branch from 1ee7e53 to 2959e76 Compare September 5, 2020 22:47
Copy link
Member

@BhaaLseN BhaaLseN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@lioncash lioncash merged commit a3dfb22 into dolphin-emu:master Sep 8, 2020
10 checks passed
@JosJuice JosJuice deleted the android-dir-init-fail-message branch September 8, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants