Android: Optimize imports #9067
Merged
+92
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not that I really mind the change, but why is this titled "optimize"? |
|
I ran the "Optimize Imports" feature of Android Studio. |
|
I suppose its main effect is to remove unused imports, but it so happens that most of what it did to Dolphin's codebase was to reorder Maybe we could update Dolphin's coding style ( |
|
Like this? |
JosJuice
approved these changes
Sep 8, 2020
lioncash
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This changed more imports than I expected so let's see what the buildbot thinks about this.