Add support for built-in input profiles

[Techjar]

They exist in the sys directory with the same structure as the config directory. Also includes a profile for controller interface Wiimote with gyro-emulated IR.

[iwubcode]

Great! I know I've seen a lot of requests for this.

Should the IMU* values be surrounded by tick marks? (actually D-pad and battery too)

[Techjar]

The UI generated this config, so I trust that it's valid and correct. I don't really understand the criteria for backticks, as it seems to work fine either way.

[BhaaLseN]

Code seems good (untested)

Just one question: can users take a built-in profile, change something and then save it as their own modified profile? Disabling save/delete is one thing, but if this prevents saving modifications it might be something to look into.

[Techjar]

Yes, changing the name to something other than the built-in one (it's an editable combo box) will re-enable the buttons.
Short video: https://qimg.techjargaming.com/v/1zSndoal.mp4

The check to disable the buttons is based on the underlying path, so if they are enabled then the file is for certain not in the sys directory.

[MayImilae]

Built-in is frankly, not great. But I can't really figure out any alternatives that do that while being short. So, I'd prefer "Dolphin Profile" instead, but that's longer. So, hmm. Well, if that fits, I'd prefer it. But built-in is fine, imo.

---

Also only sort of related but I'm very glad you only included a profile for Wii Remote with Motion Pointing. That's a genuinely very useful addon and it doesn't have any of the mapping subjectivity that comes with eeevvverythiing else. Nice! If you (or anyone else) ever want to expand this to default profiles for traditional gamepads, it's going to get messy.

[Techjar]

There's no issue with length, since the combo box size is going to depend on the window size anyways. I'm just not sure how I feel about "Dolphin Profile". Seems a bit redundant doesn't it?

I think we could include default profiles for some common and non-messy stuff. XInput is a fixed set of buttons, so that's a good candidate for GC controller. Default mapping for gamepads to wiimote is something I'm not touching with a ten-foot pole, as those are far too game-specific. In any case, we can worry about that in a different PR.

[Techjar]

I have changed the term to "Stock" in the UI, and made it translatable.

The actual profile names can't be made translatable without either A. ruining the simplicity of just putting files in the Sys directory or B. making modifications to the translation parser. I don't want to over-complicate or delay this PR, so I think it's okay if the profile names aren't translatable for now, while we work out the best way to handle that.

[MayImilae]

Alright, stock is fine. Another option would be "Included" or something, which is another route if you prefer that.

---

Regarding including more default mapping (again, this is not all that relevant to this PR, it's for future stuff I guess), I wasn't even really talking about the Xinput or Dinput issue. Even if we limit ourselves to only supporting Xinput controllers, including default mapping for gamecube and wii games is still very complex. From what I've seen, the GameCube alone has 4 different common mappings (though one of those is kind of bad), varying by personal choice and the necessities of certain titles. And the Wii... that's just a nightmare. While there are some commonalities in later Wii titles, for the most part 360 to Wii profiles have to be made unique for each and every game. Nightmare. IMO, I think it is very viable for us to ship the three major profiles for 360 to GameCube controller mapping, and perhaps classic controller as well since that one is actually easy. Just, please, for the love of all that is good and wholesome in the world, don't try to make default wii remote mappings!

EDIT: I created a list of the common mappings, I'll post it here too! https://hastebin.com/raw/arihuzezih

[Techjar]

"Included" is what I thought of, but it sounded weird, so I dug through my thesaurus and came up with "Stock".

Yeah, like I said I'm not touching default wiimote mappings with a ten-foot pole. Classic controller makes enough sense though. However, I wasn't aware there was more than one way people map 360 to GC. It has basically all the same buttons, save for a left bumper and clicky sticks, along with the face button layout being different. I can't think of more than one sensible way to bind it.

[JosJuice]

I personally map the face buttons A-B B-A X-Y Y-X to match the layout of most of Nintendo's consoles, since I'm very used to that layout. Some others map them A-A B-B X-X Y-Y because they're used to the Xbox layout or just want the button labels to match, and some others map them A-A B-X X-B Y-Y because this supposedly is the most spatially similar to the GameCube...

[jordan-woyak]

I'm a B-X X-B person but I think when we do include an Xbox controller profile we should just match the letters.
Users that are smart enough to want X to be B should be smart enough to change it.
Users that are not smart enough to change it are probably not smart enough to know X means B.

[Techjar]

Yeah, I was thinking about how to even name such profiles and I don't know how to make it not confusing, so I'm also in favor of only including a "matching labels" profile when we do that.

[MayImilae]

I would really prefer to include all three. If we only ship one, then it's like we're saying it's the correct one, and I really don't like that. As for the naming, "Direct", "Nintendo" (or SNES if you prefer), and "Spatial" I think would work well.

[mbc07]

Perhaps "GameCube Controller with Xbox button layout", "GameCube Controller with Nintendo button layout" and "GameCube Controller with spatial button layout"? That got a bit long but I think it works, however it still doesn't make clear it's intended only for XInput devices, and I can't think of a good way to inform that...

[JMC47]

Is this more or less reviewed at this point?

[devinprater]

Spacial layout sounds a bit vague, but I’m so glad this is being worked on. I hope gamepad rumble features are also considered. This would help a lot of blind users get more into Dolphin, as it’s not easy to everyone to configure all this correctly. Devin Prater d.prater@me.com Https://devinprater.github.io

…

On Sep 18, 2020, at 8:13 AM, JMC47 ***@***.***> wrote: Is this more or less reviewed at this point? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#9070 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUMTTV4YIM26W5E5NEIXN3SGNMJFANCNFSM4RA2EOKQ>.