DolphinQt: properly remove slot connection for ConfigChange when object is destructed #9076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwubcode
force-pushed
the
qt_graphics_controls_destruction
branch
from
dc1cf7b
to
a83bf8b
Compare
…t setting the receiver
|
Went ahead and fixed some other controls that had the same issue |
lioncash
approved these changes
Sep 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When destroying a Dolphin "graphics" control, we were still connected to the settings ConfigChange event. That was causing a segfault.
This is not required by any current Dolphin code but is used in #8823