Android: Get game metadata from core #9078

JosJuice · 2020-09-13T12:26:06Z

Trying to get it from a GameFile before emulation starts is unreliable.

Ebola16

This will display the gameId for the in-game emulation menu's game title. What do you think about removing the gameID there to maximize space for menu options?

JosJuice · 2020-09-13T13:13:14Z

I guess that makes sense. But what do we do in the case where the title database doesn't recognize the running game? Do we show just the game ID (like how this PR works right now) or nothing?

Ebola16 · 2020-09-13T13:18:37Z

I think displaying the game ID as a fallback if no title is found is fine.

Ebola16

Also, GeckoOS is giving me this exception on startup:
2020-09-13 09:42:12.622 8486-8486/org.dolphinemu.dolphinemu.debug E/AndroidRuntime: FATAL EXCEPTION: main
Process: org.dolphinemu.dolphinemu.debug, PID: 8486
java.lang.IllegalStateException: No game is running
at org.dolphinemu.dolphinemu.NativeLibrary.CheckGameMetadataValid(NativeLibrary.java:456)
at org.dolphinemu.dolphinemu.NativeLibrary.IsEmulatingWii(NativeLibrary.java:436)
at org.dolphinemu.dolphinemu.overlay.InputOverlay.refreshControls(InputOverlay.java:706)
at org.dolphinemu.dolphinemu.overlay.InputOverlay.initTouchPointer(InputOverlay.java:140)
at org.dolphinemu.dolphinemu.fragments.EmulationFragment.initInputPointer(EmulationFragment.java:158)
at org.dolphinemu.dolphinemu.activities.EmulationActivity.initInputPointer(EmulationActivity.java:1141)
at org.dolphinemu.dolphinemu.-$$Lambda$VaQ0DnlfVw6B_598YlWOOA_cqe0.run(Unknown Source:2)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:7073)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)

JosJuice · 2020-09-13T14:01:45Z

Both problems should now be fixed. (Regarding Gecko OS, I hadn't taken into account that Host_TitleChanged doesn't get called on boot for DOL/ELF files.)

Ebola16 · 2020-09-13T15:01:50Z

Even with the most recent push, I'm getting a (unhelpful) DeadObjectException when loading GeckoOS. I double checked by trying on Master and it works fine so the problem isn't with my setup.

Ebola16 · 2020-09-13T15:08:35Z

Nevermind, it's the combination of https://bugs.dolphin-emu.org/issues/11113 and Android Dolphin resetting my default controls upon reinstall.

JosJuice · 2020-09-13T15:13:30Z

I don't really get how that could cause a DeadObjectException... But I'll ignore it then.

Ebola16 · 2020-09-13T15:25:57Z

GeckoOS now launches properly but but I'm getting the same DeadObjectException when choosing "Launch Game", even with accounting for https://bugs.dolphin-emu.org/issues/11113.
When the point where noting is displayed for the in-game emulation menu game title is reached, can we instead display the game filename? This is much more useful info. It can let users know if they're currently using a mod launcher if they can't remember.

JosJuice · 2020-09-13T15:47:06Z

I tried turning off Wii Remotes and launching Xenoblade Chronicles through Gecko OS (saying yes to when Gecko OS asked me to install IOS 53), and it worked perfectly for me. Do you have any details on what's triggering the exception? I would assume it has something to do with the call to Host_TitleChanged, but I'm not sure.

I will try to create a separate PR (for all platforms) for displaying a name for DOL/ELF files. (I don't believe it's possible to reach the case where nothing, not even a game ID, is displayed when running a disc or WAD.)

JosJuice · 2020-09-13T15:49:13Z

It can let users know if they're currently using a mod launcher if they can't remember.

Perhaps I should mention this explicitly: With this PR, when you launch a game through something like Gecko OS, the title will update to match the game you launched. This is one of the advantages of getting the title from the core.

Ebola16

Perhaps I should mention this explicitly: With this PR, when you launch a game through something like Gecko OS, the title will update to match the game you launched. This is one of the advantages of getting the title from the core.

Now that I've gotten to the point where mods were loaded in this PR, I was able to notice that change and it makes sense.

Source/Android/jni/MainAndroid.cpp

Ebola16

That fixed the problem. I don't have much C++ review experience but as far as I can tell this PR LGTM.

JosJuice · 2020-09-14T19:07:42Z

I've managed to reproduce the crash now (with the last commit reverted). The reason why I couldn't reproduce it before was because it only happens with fastmem on and I had accidentally left fastmem off (since I need it off when using the debugger). Unfortunately, this means that I can't use the debugger to figure out what's going on, and I would really like to know what's going on before this gets merged. I'm also not getting a DeadObjectException – my old phone says SIGSEGV and my new phone says nothing at all. I'm assuming the DeadObjectException is actually just a symptom of the underlying native crash.

leoetlino · 2020-10-20T12:49:39Z

Source/Android/jni/MainAndroid.cpp

@@ -152,8 +152,10 @@ void Host_TitleChanged()
 {
  s_game_metadata_is_valid = true;

-  JNIEnv* env = IDCache::GetEnvForThread();
-  env->CallStaticVoidMethod(IDCache::GetNativeLibraryClass(), IDCache::GetOnTitleChanged());
+  std::thread([] {


This should have a comment explaining why this is required.

The problem is that I have no idea why this is required. It's the one thing keeping this PR from being mergeable in my opinion.

I had a similar issue and know where it crashes. The culprit is JVM's AttachCurrentThread in GetEnvForThread.

In IDCache.cpp:

if (status == JNI_EDETACHED) s_java_vm->AttachCurrentThread(&env, nullptr);

The things is, for me at least, it raises randomly many different type of exceptions/errors such as segfault, libc/stack corruption, memory access errors, etc. I tried to find any relevant pieces of documentation regarding this behaviour but couldn't find any. I also don't know (yet) how to debug native code so I couldn't go deeper.

I suspect there is something fishy in that function and that depending on how the thread was created it might produce an undefined behaviour.

Hmm, so AttachCurrentThread fails if we call it from the CPU thread, but only when fastmem is enabled... Maybe we could make sure to attach the CPU thread before enabling fastmem? I'll give that a try.

That seems to do the trick. I'm much happier with this than the earlier workaround.

My new commit calls AttachCurrentThread before EMM::InstallExceptionHandler, but calling it immediately afterwards also seems to work. Perhaps the problem only occurs after the first fastmem fault rather than after the exception handler is installed?

JosJuice · 2020-10-21T10:57:08Z

This should be ready for merge now.

Source/Core/Core/Core.cpp

A title change to a title with no game ID is still a title change.

Trying to get it from a GameFile before emulation starts is unreliable.

JosJuice mentioned this pull request Sep 13, 2020

Android: Improve WRITE_EXTERNAL_STORAGE denial #9061

Merged

Ebola16 reviewed Sep 13, 2020

View reviewed changes

Ebola16 suggested changes Sep 13, 2020

View reviewed changes

JosJuice force-pushed the android-metadata-from-core branch from c0cfe4a to bf290bf Compare September 13, 2020 14:00

JosJuice force-pushed the android-metadata-from-core branch from bf290bf to e7b23cc Compare September 13, 2020 14:47

JosJuice force-pushed the android-metadata-from-core branch from e7b23cc to 935cabc Compare September 14, 2020 07:57

Ebola16 suggested changes Sep 14, 2020

View reviewed changes

Source/Android/jni/MainAndroid.cpp Show resolved Hide resolved

Ebola16 approved these changes Sep 14, 2020

View reviewed changes

JosJuice force-pushed the android-metadata-from-core branch 4 times, most recently from 98e6d3d to d8de4c2 Compare September 17, 2020 16:12

JosJuice force-pushed the android-metadata-from-core branch from d8de4c2 to 1a48fbf Compare October 19, 2020 18:48

leoetlino reviewed Oct 20, 2020

View reviewed changes

JosJuice force-pushed the android-metadata-from-core branch from 1a48fbf to 84fff1b Compare October 21, 2020 10:40

leoetlino reviewed Oct 21, 2020

View reviewed changes

Source/Core/Core/Core.cpp Outdated Show resolved Hide resolved

JosJuice added 3 commits October 21, 2020 19:57

Core: Set bWii before calling Host_TitleChanged

1ddf727

Core: Always call Host_TitleChanged on boot

b6fcfcb

A title change to a title with no game ID is still a title change.

Android: Get game metadata from core

0dc29c7

Trying to get it from a GameFile before emulation starts is unreliable.

Android: Don't show game ID after game title

3a09173

JosJuice force-pushed the android-metadata-from-core branch from 84fff1b to 80360d2 Compare October 21, 2020 18:07

Android: Attach CPU thread to JVM early

e86d713

JosJuice force-pushed the android-metadata-from-core branch from 80360d2 to e86d713 Compare October 21, 2020 19:10

leoetlino approved these changes Oct 21, 2020

View reviewed changes

leoetlino merged commit 18b2553 into dolphin-emu:master Oct 21, 2020
10 checks passed

JosJuice deleted the android-metadata-from-core branch October 21, 2020 20:32

JosJuice mentioned this pull request Oct 24, 2020

IP/Top: Add Android network interface #9191

Merged

Android: Get game metadata from core #9078

Android: Get game metadata from core #9078

JosJuice commented Sep 13, 2020

Ebola16 left a comment •

edited

JosJuice commented Sep 13, 2020 •

edited

Ebola16 commented Sep 13, 2020

Ebola16 left a comment •

edited

JosJuice commented Sep 13, 2020

Ebola16 commented Sep 13, 2020 •

edited

Ebola16 commented Sep 13, 2020 •

edited

JosJuice commented Sep 13, 2020

Ebola16 commented Sep 13, 2020 •

edited

JosJuice commented Sep 13, 2020 •

edited

JosJuice commented Sep 13, 2020 •

edited

Ebola16 left a comment

Ebola16 left a comment

JosJuice commented Sep 14, 2020

leoetlino Oct 20, 2020

JosJuice Oct 20, 2020

sepalani Oct 20, 2020

JosJuice Oct 21, 2020

JosJuice Oct 21, 2020

JosJuice commented Oct 21, 2020

Android: Get game metadata from core #9078

Android: Get game metadata from core #9078

Conversation

JosJuice commented Sep 13, 2020

Ebola16 left a comment • edited

Choose a reason for hiding this comment

JosJuice commented Sep 13, 2020 • edited

Ebola16 commented Sep 13, 2020

Ebola16 left a comment • edited

Choose a reason for hiding this comment

JosJuice commented Sep 13, 2020

Ebola16 commented Sep 13, 2020 • edited

Ebola16 commented Sep 13, 2020 • edited

JosJuice commented Sep 13, 2020

Ebola16 commented Sep 13, 2020 • edited

JosJuice commented Sep 13, 2020 • edited

JosJuice commented Sep 13, 2020 • edited

Ebola16 left a comment

Choose a reason for hiding this comment

Ebola16 left a comment

Choose a reason for hiding this comment

JosJuice commented Sep 14, 2020

leoetlino Oct 20, 2020

Choose a reason for hiding this comment

JosJuice Oct 20, 2020

Choose a reason for hiding this comment

sepalani Oct 20, 2020

Choose a reason for hiding this comment

JosJuice Oct 21, 2020

Choose a reason for hiding this comment

JosJuice Oct 21, 2020

Choose a reason for hiding this comment

JosJuice commented Oct 21, 2020

Ebola16 left a comment •

edited

JosJuice commented Sep 13, 2020 •

edited

Ebola16 left a comment •

edited

Ebola16 commented Sep 13, 2020 •

edited

Ebola16 commented Sep 13, 2020 •

edited

Ebola16 commented Sep 13, 2020 •

edited

JosJuice commented Sep 13, 2020 •

edited

JosJuice commented Sep 13, 2020 •

edited