MMU: fix enhanced BAT support #908
Conversation
| @@ -841,63 +841,53 @@ static u32 TranslatePageAddress(const u32 _Address, const XCheckTLBFlag _Flag) | |||
| #define BAT_EA_11(v) ((v)&0x0ffe0000) | |||
| #define BAT_EA_4(v) ((v)&0xf0000000) | |||
|
|
|||
| static inline bool CheckAddrBats(const u32 addr, u32& result, u32 batu, u32 spr) | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
I don't know what I can test this on, but it was definitely broken before. Seems to be a few clock cycles faster too due to the refactoring?
FioraAeterna
force-pushed
the
fixenhancedbat
branch
from
ea6387b
to
08ab2d3
Compare
|
By the way if anyone knows any games that trigger this I would so love to know |
|
For Ultimate Spider-Man and Star Wars: Rogue Leader, Bat was enabled in the gameini with 3.5 dolphin. Btw Fiora since you are trying to optimize Jit stuff, all Telltale games seem to be extremely cpu bound for some reason that it seems a bit off. Back to the future (wii) and Tales of Monkey Island (wiiware) are running extremely slow for example to the point Last Story seems nothing. Sorry for the offtopic btw. |
|
Code looks fine. No games made use of the secondary BAT to my knowledge. |
|
@FioraAeterna: This comment grants you the permission to merge this pull request whenever you think it is ready. After addressing the remaining comments, click this link to merge. @dolphin-emu-bot allowmerge |
MMU: fix enhanced BAT support
I don't know what I can test this on, but it was definitely broken before.
Seems to be a few clock cycles faster too due to the refactoring?