Qt: Use better method of getting default monospace font #9085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're using the same approach in the log widget. I assume it would make sense to change that as well? dolphin/Source/Core/DolphinQt/Config/LogWidget.cpp Lines 122 to 123 in 82012c4 |
|
Ah, I wasn't aware it was separate. |
This should give us a nicer font on Windows, while also not severely impacting the existing behavior on Linux.
|
Before:
After:
And the after runs ~10X smoother. |
Techjar
force-pushed
the
better-monospace
branch
from
19fbb88
to
0759ead
Compare
Techjar
changed the title
lioncash
approved these changes
Sep 15, 2020
|
This fixes the startup delay observed in macOS as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This should give us a nicer font on Windows, while also not severely impacting the existing behavior on Linux.
At least on my Linux system, it actually results in using the monospace font I have configured (which is "Hack").
Before ("Monospace")
After ("Hack")
